Fix access level violation #17
Conversation
| * @param ObjectManager $manager | ||
| * @param array $options | ||
| * @return EntityLoaderInterface | ||
| * @param \Doctrine\Common\Persistence\ObjectManager $manager |
There was a problem hiding this comment.
Please use the short class name in the phpdoc here (as done previously)
There was a problem hiding this comment.
I used PHPStorm, and it automatically generated that -- sucks because it didn't notice the use statements. I imagine this would also effect code completion for other IDEs, but I can short name the ObjectManager, and the FormException, but I have to put in a use stateument to shorten the EntityLoaderInterface for it to be resolve correctly.
I'm not sure what the style guide is here, should I short name everything, and put in the appropriate use statements? Or only shorten the items that have use statements and remain resolvable?
There was a problem hiding this comment.
There was a problem hiding this comment.
And btw, PhpStorm 5 handles use statements properly when resolving the phpdoc, even if it generates it with the FQCN.
The getLoader interface has changed and this causes immediate breakage (even upon something simple like php app/console). I've updated it here, fixed up the doc comment (now correctly indicates that this will immediately throw an exception).
|
Redone, using all short names. |
|
Actually, I have merge rights on this repo so let's merge :) |
Fix access level violation Closes #16
The getLoader interface has changed and this causes immediate breakage (even upon something simple like php app/console).
I've updated it here, fixed up the doc comment (now correctly indicates that this will immediately throw an exception).